From 8d1809edb32a38930f65bfaa720de5deeb8d5931 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 1 Apr 2015 11:44:51 +0200
Subject: [PATCH] src: fix `Illegal string offset' warning in firewall rules

---
 src/www/firewall_rules.php | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php
index 57f63a9dd..4b0880942 100644
--- a/src/www/firewall_rules.php
+++ b/src/www/firewall_rules.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
 	Copyright (C) 2014-2015 Deciso B.V.
 	Copyright (C) 2005 Scott Ullrich (sullrich@gmail.com)
@@ -152,20 +153,24 @@ if ($config['pptpd']['mode'] == "server")
 		$iflist['pptp'] = "PPTP VPN";
 
 if (is_array($config['pppoes']['pppoe'])) {
-	foreach ($config['pppoes']['pppoe'] as $pppoes)
-		if (($pppoes['mode'] == 'server') && have_ruleint_access("pppoe"))
+	foreach ($config['pppoes']['pppoe'] as $pppoes) {
+		if (($pppoes['mode'] == 'server') && have_ruleint_access('pppoe')) {
 			$iflist['pppoe'] = "PPPoE Server";
+		}
+	}
 }
 
 /* add ipsec interfaces */
-if (isset($config['ipsec']['enable']) || isset($config['ipsec']['client']['enable']))
-	if(have_ruleint_access("enc0"))
-		$iflist["enc0"] = "IPsec";
+if (isset($config['ipsec']['enable']) || isset($config['ipsec']['client']['enable'])) {
+	if (have_ruleint_access('enc0')) {
+		$iflist['enc0'] = 'IPsec';
+	}
+}
 
 /* add openvpn/tun interfaces */
-if  ($config['openvpn']["openvpn-server"] || $config['openvpn']["openvpn-client"])
-	$iflist["openvpn"] = "OpenVPN";
-
+if (isset($config['openvpn']['openvpn-server']) || isset($config['openvpn']['openvpn-client'])) {
+	$iflist['openvpn'] = 'OpenVPN';
+}
 
 if (!$if || !isset($iflist[$if])) {
 	if ("any" == $if)