From 8c52aa1964ee80ff62fbde7597d5aa34c71ca1ab Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 19 Nov 2018 12:37:32 +0100 Subject: [PATCH] Portfield validation, missed a spot in https://github.com/opnsense/core/issues/2916 --- .../mvc/app/models/OPNsense/Base/FieldTypes/PortField.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php index 84735815c..981dedf0d 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php @@ -149,8 +149,10 @@ class PortField extends BaseField { $validators = parent::getValidators(); if ($this->internalValidationMessage == null) { - $msg = "please specify a valid port number (1-65535) or name (" . implode(",", self::$wellknownservices) . - ")"; + $msg = "please specify a valid port number (1-65535)"; + if ($this->enableWellKown) { + $msg .= " or name (" . implode(",", self::$wellknownservices) . ")"; + } } else { $msg = $this->internalValidationMessage; }