From 86ffbd88ad3941cc972ce2ffb42b1b30a650500d Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Thu, 10 Apr 2025 12:42:00 +0200
Subject: [PATCH] firmware: this broke too

---
 src/opnsense/scripts/firmware/check.sh  | 2 +-
 src/opnsense/scripts/firmware/reboot.sh | 2 +-
 src/opnsense/scripts/firmware/update.sh | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/opnsense/scripts/firmware/check.sh b/src/opnsense/scripts/firmware/check.sh
index b9e544217..d40330aca 100755
--- a/src/opnsense/scripts/firmware/check.sh
+++ b/src/opnsense/scripts/firmware/check.sh
@@ -68,7 +68,7 @@ sets_upgraded=
 upgrade_needs_reboot="0"
 
 product_reboot=$(/usr/local/sbin/pluginctl -g system.firmware.reboot)
-if [ -n "${product_reboot}" ]; then
+if [ "${product_reboot}" = "1" ]; then
 	needs_reboot="1"
 fi
 
diff --git a/src/opnsense/scripts/firmware/reboot.sh b/src/opnsense/scripts/firmware/reboot.sh
index 32584a4c2..5eff33069 100755
--- a/src/opnsense/scripts/firmware/reboot.sh
+++ b/src/opnsense/scripts/firmware/reboot.sh
@@ -60,7 +60,7 @@ if [ -n "${LQUERY}" -a -n "${RQUERY}" ]; then
 fi
 
 ALWAYS_REBOOT=$(/usr/local/sbin/pluginctl -g system.firmware.reboot)
-if [ -n "${ALWAYS_REBOOT}" ]; then
+if [ "${ALWAYS_REBOOT}" = "1" ]; then
 	WANT_REBOOT=0
 fi
 
diff --git a/src/opnsense/scripts/firmware/update.sh b/src/opnsense/scripts/firmware/update.sh
index d5ff04e04..1edf48a7e 100755
--- a/src/opnsense/scripts/firmware/update.sh
+++ b/src/opnsense/scripts/firmware/update.sh
@@ -65,7 +65,7 @@ if opnsense-update ${FORCE} -bk -c; then
 	fi
 fi
 
-if [ -n "${ALWAYS_REBOOT}" ]; then
+if [ "${ALWAYS_REBOOT}" = "1" ]; then
 	if [ "${PKGS_HASH}" != "$(${PKG} query %n-%v 2> /dev/null | sha256)" ]; then
 		output_reboot
 	fi