From 822df6cc6909c776e3207ac5cb2578f5ad883e9a Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 19 Jul 2024 08:39:46 +0200 Subject: [PATCH] Lobby: Dashboard - add a safety fence in productInfoFeedAction() in case the firewall has no intrenet access. Fixes: Error: Call to a member function children() on null in /usr/local/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php:201 Stack trace: --- .../app/controllers/OPNsense/Core/Api/DashboardController.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php index 0190170d8..d9257957a 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php @@ -201,6 +201,9 @@ class DashboardController extends ApiControllerBase $output = curl_exec($ch); curl_close($ch); $payload = simplexml_load_string($output); + if (empty($payload)) { + return $result; + } foreach ($payload->channel->children() as $key => $node) { if ($key == 'item') { $result['items'][] = [