From 80ce75e37306d8c23aec9c9569286ccbdd2142bd Mon Sep 17 00:00:00 2001
From: Michael <m.muenz@gmail.com>
Date: Mon, 26 Mar 2018 11:30:23 +0200
Subject: [PATCH] Fix help text in Traffic Shaper masks (#2293)

* Update dialogPipe.xml

* Update dialogQueue.xml

* Update dialogPipe.xml

* Update dialogQueue.xml
---
 .../controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml  | 5 +++--
 .../controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml b/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml
index caf9cdb23..9e0859b7c 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml
+++ b/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml
@@ -28,8 +28,9 @@
         <label>mask</label>
         <type>dropdown</type>
         <help><![CDATA[Dynamic queue creation by source or destination address.
-        <li> choose destination here to share the total bandwidth of this pipe among all connected clients. </li>
-        <li> choose source to provide all connected clients up to a maximum of this pipe configured bandwidth  </li>
+        <li>Choose destination to give every IP in destination field of rules the specified bandwith. A pipe with 1Mbit e.g. would let 3 clients lend 1Mbit each so 3Mbit max. Normally this is used for download pipes.</li>
+        <li>Choose source to give every IP in the source field of rules the specified bandwith. Normally this is used for download pipes.</li>
+        <li>Leave this value empty if you want to create a pipe with a fixed bandwith.</li>
         ]]></help>
     </field>
     <field>
diff --git a/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml b/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml
index 219f524ee..f130c5349 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml
+++ b/src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml
@@ -22,8 +22,9 @@
         <label>mask</label>
         <type>dropdown</type>
         <help><![CDATA[Dynamic queue creation by source or destination address.
-        <li> choose destination here to share the total bandwidth of this pipe among all connected clients. </li>
-        <li> choose source to provide all connected clients up to a maximum of this pipe configured bandwidth  </li>
+        <li>Choose destination to evenly share every IP in destination field of rules the specified bandwith. A pipe with 1Mbit e.g. would let 4 clients lend 250Kbit each. Normally this is used for download queues.</li>
+        <li>Choose source to evenly share every IP in the source field of rules the specified bandwith. Normally this is used for upload queues.</li>
+        <li>Leave this value empty if you want to specify multiple queues with different weights.</li>
         ]]></help>
     </field>
     <field>