From 7fd17d527dce9ed93c4fd2054787b1a2f2fc44b4 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Wed, 12 Feb 2025 18:39:49 +0100
Subject: [PATCH] Firewall: Rules - hide internal aliases to align with
 previous legacy_list_aliases() function. closes
 https://github.com/opnsense/core/issues/8322

---
 .../OPNsense/Firewall/Api/FilterBaseController.php           | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
index ca04d624f..13315a969 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
@@ -110,7 +110,10 @@ abstract class FilterBaseController extends ApiMutableModelControllerBase
             }
         }
         foreach ((new Alias())->aliases->alias->iterateItems() as $alias) {
-            if (strpos((string)$alias->type, "port") === false) {
+            if ($alias->type == 'internal') {
+                /* currently only used for legacy bindings, align with legacy_list_aliases() usage */
+                continue;
+            } elseif (strpos((string)$alias->type, "port") === false) {
                 $result['aliases']['items'][(string)$alias->name] = (string)$alias->name;
             }
         }