From 7fa1f8b8bee0e307ed7e2c24e649147167c363a4 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Thu, 3 Feb 2022 07:52:09 +0100
Subject: [PATCH] system: only log on automatic far gateway detect #5493

---
 src/etc/inc/system.inc | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/etc/inc/system.inc b/src/etc/inc/system.inc
index e670f830d..47e77f8c1 100644
--- a/src/etc/inc/system.inc
+++ b/src/etc/inc/system.inc
@@ -482,11 +482,13 @@ function system_default_route($gateway, $family, $interface, $far = false)
         log_error("ROUTING: creating /tmp/{$realif}_defaultgw using '{$gateway}'");
         @file_put_contents("/tmp/{$realif}_defaultgw", $gateway);
 
-        list (, $network) = interfaces_primary_address($interface);
-        if (!$far && ip_in_subnet($gateway, $network)) {
-            $realif = null;
-        } else {
-            log_error("ROUTING: treating gateway '{$gateway}' as far gateway");
+        if (!$far) {
+            list (, $network) = interfaces_primary_address($interface);
+            if (ip_in_subnet($gateway, $network)) {
+                $realif = null;
+            } else {
+                log_error("ROUTING: treating gateway '{$gateway}' as far gateway");
+            }
         }
     } else {
         foreach (glob('/tmp/*_defaultgwv6') as $to_delete) {