From 7ce814346bf4ea1680ebeff9e509c7b6adb09d50 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Thu, 22 Aug 2024 14:36:09 +0200
Subject: [PATCH] interfaces: add logging to PPP link scripts to check for
 overlap

Currently we neither see when we spawn a new mpd5 daemon nor when
the PPPoE starts or stops working or if there is any overlap.
---
 src/opnsense/scripts/interfaces/ppp-linkdown.sh | 4 +---
 src/opnsense/scripts/interfaces/ppp-linkup.sh   | 2 ++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/opnsense/scripts/interfaces/ppp-linkdown.sh b/src/opnsense/scripts/interfaces/ppp-linkdown.sh
index 1b09479b2..5241dc056 100755
--- a/src/opnsense/scripts/interfaces/ppp-linkdown.sh
+++ b/src/opnsense/scripts/interfaces/ppp-linkdown.sh
@@ -4,10 +4,8 @@ export PATH=/bin:/usr/bin:/usr/local/bin:/sbin:/usr/sbin:/usr/local/sbin
 
 IF="${1}"
 AF="${2}"
-IP="${3}"
-GW=
 
-DEFAULTGW=$(route -n get -${AF} default | grep gateway: | awk '{print $2}')
+/usr/bin/logger -t ppp "ppp-linkdown: executing on ${1} for ${2}"
 
 ngctl shutdown ${IF}:
 
diff --git a/src/opnsense/scripts/interfaces/ppp-linkup.sh b/src/opnsense/scripts/interfaces/ppp-linkup.sh
index c7b261057..a86df995b 100755
--- a/src/opnsense/scripts/interfaces/ppp-linkup.sh
+++ b/src/opnsense/scripts/interfaces/ppp-linkup.sh
@@ -18,6 +18,8 @@ if [ -n "${4}" ]; then
 	ROUTER="-a $(echo ${4} | cut -d% -f1)"
 fi
 
+/usr/bin/logger -t ppp "ppp-linkup: executing on ${1} for ${2}"
+
 if [ "${2}" = "inet" ]; then
 	/usr/local/sbin/ifctl -i ${1} -4nd ${DNS1} ${DNS2}
 	/usr/local/sbin/ifctl -i ${1} -4rd ${ROUTER}