From 7a5a2712cdb8dc5cb4e2b7fae46430bd8849799f Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Thu, 10 Oct 2019 20:54:55 +0200 Subject: [PATCH] tokenize2 fix for https://github.com/opnsense/core/issues/3760 https://github.com/opnsense/core/commit/a4217d8fcccad2676fc6e449d15df3437d814bff calls tokenize2() before it seems to be inititalized, lets check for content before calling clear. --- src/opnsense/www/js/opnsense.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/www/js/opnsense.js b/src/opnsense/www/js/opnsense.js index db8aa830f..bec98fb47 100644 --- a/src/opnsense/www/js/opnsense.js +++ b/src/opnsense/www/js/opnsense.js @@ -135,13 +135,13 @@ function setFormData(parent,data) { // data node found, handle per type if (targetNode.is("select")) { // handle select boxes - targetNode.empty(); // flush - if (targetNode.hasClass("tokenize")) { + if (targetNode.find('option').length > 0 && targetNode.hasClass("tokenize")) { // when setting the same content twice to a widget, tokenize2 sorting mixes up. // Ideally formatTokenizersUI() or tokenize2 should handle this better, but for now // this seems like the only fix that actually works. targetNode.tokenize2().trigger('tokenize:clear'); } + targetNode.empty(); // flush $.each(node[keypart],function(indxItem, keyItem){ var opt = $("