From 79ab5ec44af76dc365d2131575b2ba40ec28c024 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Wed, 5 Jun 2024 13:30:20 +0200
Subject: [PATCH] Firewall: Aliases / generic MVC - performance improvments,
 closes https://github.com/opnsense/core/issues/7509

fix regression in earlier commit.
---
 src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php b/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
index bc164d3b9..6a8755175 100644
--- a/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
+++ b/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
@@ -223,9 +223,7 @@ class Alias extends BaseModel
         if (empty($this->aliasReferenceCache)) {
             // cache alias uuid references, but always validate existence before return.
             foreach ($this->aliases->alias->iterateItems() as $uuid => $alias) {
-                if ((string)$alias->name == $name) {
-                    $this->aliasReferenceCache[(string)$alias->name] = $alias;
-                }
+                $this->aliasReferenceCache[(string)$alias->name] = $alias;
             }
         }
         if (isset($this->aliasReferenceCache[$name])) {