From 77569c29fb686cc5deccadf4004a6d9be91d5599 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Mon, 3 Oct 2022 15:27:00 +0200
Subject: [PATCH] Firewall: NAT: Port Forward - php8 error when using
 any-{port} or {port}-any in destinations. fix local-port calculation

---
 src/www/firewall_nat.php | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/www/firewall_nat.php b/src/www/firewall_nat.php
index 5fedd6d2e..f4756decf 100644
--- a/src/www/firewall_nat.php
+++ b/src/www/firewall_nat.php
@@ -487,11 +487,14 @@ $( document ).ready(function() {
 
                       <td>
 <?php
-                        $localport = $natent['local-port'];
+                         $localport = $natent['local-port'];
                          if (strpos($natent['destination']['port'],'-') !== false) {
+                            $natlocalport = preg_match('/^(\d){1,4}$/', $natent['local-port']) ? (int)$natent['local-port'] : 1;
                             list($dstbeginport, $dstendport) = explode("-", $natent['destination']['port']);
-                            $localendport = $natent['local-port'] + $dstendport - $dstbeginport;
-                            $localport   .= '-' . $localendport;
+                            $dstbeginport = preg_match('/^\d*$/', $dstbeginport) ? (int)$dstbeginport : 1;
+                            $dstendport = preg_match('/^\d*$/', $dstendport) ? (int)$dstendport : 65535;
+                            $localendport = $natlocalport + $dstendport - $dstbeginport;
+                            $localport   .= '-' . $localendport ;
                         }
 ?>
 <?php                   if (isset($natent['local-port']) && is_alias($natent['local-port'])): ?>