From 7669c6c56e3a34835d844eeedbff2c21664cb28a Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Sun, 10 May 2020 00:57:18 +0200
Subject: [PATCH] logging / reverse setting not used anymore in core, lets drop
 it now. for https://github.com/opnsense/core/issues/4068

There might be a couple of plugins still using the old log viewer, but since the default setting is usually left intact, it should be safe to remove it now.
---
 src/www/diag_logs_settings.php | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/www/diag_logs_settings.php b/src/www/diag_logs_settings.php
index 00b7f59ea..b9b8f8a7a 100644
--- a/src/www/diag_logs_settings.php
+++ b/src/www/diag_logs_settings.php
@@ -58,7 +58,6 @@ function is_valid_syslog_server($target) {
 
 if ($_SERVER['REQUEST_METHOD'] === 'GET') {
     $pconfig = array();
-    $pconfig['reverse'] = isset($config['syslog']['reverse']);
     $pconfig['disable_clog'] = isset($config['syslog']['disable_clog']);
     $pconfig['logfilesize'] =  !empty($config['syslog']['logfilesize']) ? $config['syslog']['logfilesize'] : null;
     $pconfig['preservelogs'] =  !empty($config['syslog']['preservelogs']) ? $config['syslog']['preservelogs'] : null;
@@ -90,7 +89,6 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
         }
 
         if (count($input_errors) == 0) {
-            $config['syslog']['reverse'] = !empty($pconfig['reverse']);
             $config['syslog']['disable_clog'] = !empty($pconfig['disable_clog']);
             if (isset($_POST['logfilesize']) && (strlen($pconfig['logfilesize']) > 0)) {
                 $config['syslog']['logfilesize'] = (int)$pconfig['logfilesize'];
@@ -208,15 +206,6 @@ $(document).ready(function() {
                       <i class="fa fa-toggle-off text-danger" style="cursor: pointer;" id="show_all_help_page"></i>
                     </td>
                   </tr>
-                  <tr>
-                    <td><a id="help_for_reverse" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext('Reverse Display') ?></td>
-                    <td>
-                      <input name="reverse" type="checkbox" id="reverse" value="yes" <?=!empty($pconfig['reverse']) ? "checked=\"checked\"" : ""; ?> />
-                      <div class="hidden" data-for="help_for_reverse">
-                        <?=gettext("Show log entries in reverse order (newest entries on top)");?>
-                      </div>
-                    </td>
-                  </tr>
                   <tr>
                     <td><a id="help_for_circular_logs" href="#" class="showhelp"><i class="fa fa-info-circle"></i></a> <?=gettext("Disable circular logs");?></td>
                     <td>