From 73030fb52870f5bc0652f755dd2f7560d7da7ab7 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Sun, 7 Mar 2021 10:42:24 +0100
Subject: [PATCH] Auth/LDAP: minor tweak for
 https://github.com/opnsense/core/pull/4784, only log message when there is
 one.

---
 src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php
index 562cfe2f5..5fabae3b5 100644
--- a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php
+++ b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php
@@ -201,7 +201,9 @@ class LDAP extends Base implements IAuthConnector
             ldap_get_option($this->ldapHandle, LDAP_OPT_ERROR_STRING, $error_string);
             $error_string = str_replace(array("\n","\r","\t"), ' ', $error_string);
             syslog(LOG_ERR, sprintf($message . " [%s; %s]", $error_string, ldap_error($this->ldapHandle)));
-            $this->lastAuthErrors['error'] = $error_string;
+            if (!empty($error_string)) {
+                $this->lastAuthErrors['error'] = $error_string;
+            }
             $this->lastAuthErrors['ldap_error'] = ldap_error($this->ldapHandle);
         } else {
             syslog(LOG_ERR, $message);