From 7273bba2c1b0b06bc07dbe4c44677b3381968318 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sat, 3 Jun 2023 09:45:57 +0200 Subject: [PATCH] Services: Monit: Settings - fix "not on" validation. closes https://github.com/opnsense/core/issues/6591 --- .../mvc/app/models/OPNsense/Monit/Monit.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php b/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php index 564fe4077..a5e52b948 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php +++ b/src/opnsense/mvc/app/models/OPNsense/Monit/Monit.php @@ -163,6 +163,19 @@ class Monit extends BaseModel $parentNode = $node->getParentNode(); // perform plugin specific validations switch ($parentNode->getInternalXMLTagName()) { + case 'alert': + switch ($node->getInternalXMLTagName()) { + case 'noton': + case 'events': + if (!empty((string)$parentNode->noton) && empty((string)$parentNode->events)) { + $messages->appendMessage(new Message( + gettext("At least one event should be selected when using and inverted selection."), + $key + )); + } + break; + } + break; case 'test': // test node validations switch ($node->getInternalXMLTagName()) {