From 67910fbfeab0e1754507a6b7f0eaafdf1ece319f Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 10 Dec 2021 17:22:26 +0100 Subject: [PATCH] Services: Intrusion Detection - rule downloads : gently log when connectivity issues appear. --- src/opnsense/scripts/suricata/lib/downloader.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/opnsense/scripts/suricata/lib/downloader.py b/src/opnsense/scripts/suricata/lib/downloader.py index 4438a5d30..d2bb14c58 100755 --- a/src/opnsense/scripts/suricata/lib/downloader.py +++ b/src/opnsense/scripts/suricata/lib/downloader.py @@ -107,7 +107,11 @@ class Downloader(object): req_opts['auth'] = auth if headers is not None: req_opts['headers'] = headers - req = requests.get(**req_opts) + try: + req = requests.get(**req_opts) + except requests.exceptions.RequestException as e: + syslog.syslog(syslog.LOG_ERR, 'download failed for %s (%s)' % (url, e)) + return None if 'content-disposition' not in req.headers \ or req.headers['content-disposition'].find('filename=') == -1: filename = url.strip().lower().split('?')[0]