From 651edfe7c49dae231cc5d2fde198783066ddf3e7 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sat, 11 Mar 2023 21:40:44 +0100 Subject: [PATCH] Interfaces: Diagnostics: Packet Capture - make sure output buffering is disabled and add headers for the download. closes https://github.com/opnsense/core/issues/6321 --- .../OPNsense/Diagnostics/Api/PacketCaptureController.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php index 514e272ce..69cb63515 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/PacketCaptureController.php @@ -156,6 +156,11 @@ class PacketCaptureController extends ApiMutableModelControllerBase if (!empty($payload) && !empty($payload['filename'])) { $this->response->setContentType('application/octet-stream'); $this->response->setRawHeader("Content-Disposition: attachment; filename=" . basename($payload['filename'])); + $this->response->setRawHeader("Content-length: " . filesize($payload['filename'])); + $this->response->setRawHeader("Pragma: no-cache"); + $this->response->setRawHeader("Expires: 0"); + ob_clean(); + flush(); readfile($payload['filename']); } }