From 63af98ed5b9dc10a0ebfa8df02a136691a2f65dc Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Mon, 29 Mar 2021 12:10:10 +0200
Subject: [PATCH] firmware: rework previous, status action on POST is sync

---
 .../OPNsense/Core/Api/FirmwareController.php           | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
index c5026c80e..a0c71d9f1 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
@@ -65,14 +65,14 @@ class FirmwareController extends ApiControllerBase
      * Run check for updates
      * @return array
      */
-    public function checkAction($sync)
+    public function checkAction()
     {
         $this->sessionClose(); // long running action, close session
         $response = [];
 
         if ($this->request->isPost()) {
             $backend = new Backend();
-            $response['msg_uuid'] = trim($backend->configdRun('firmware check', empty($sync) ? true : false));
+            $response['msg_uuid'] = trim($backend->configdRun('firmware check', true));
             $response['status'] = 'ok';
         } else {
             $response['status'] = 'failure';
@@ -94,6 +94,12 @@ class FirmwareController extends ApiControllerBase
         $backend = new Backend();
         $target = null;
 
+        $this->sessionClose(); // long running action, close session
+
+        if ($this->request->isPost()) {
+            $backend->configdRun('firmware check');
+        }
+
         $response = json_decode(trim($backend->configdRun('firmware product')), true);
         if ($response != null && $response['product_check'] != null) {
             $response = $response['product_check'];