lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-19 19:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

(systemhealth) don't generate crash report on empty or invalid rrd xml data

Browse Source
This commit is contained in:
Ad Schellevis 2016-04-11 13:36:20 +02:00
parent a35211fdef
commit 5e4a007307
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/SystemhealthController.php
View File

@ -542,13 +542,11 @@ class SystemhealthController extends ApiControllerBase
*/
$rrd_details=$this->getRRDdetails($rrd)["data"];
$xml = false;
if ($rrd_details['filename'] != "") {
$backend = new Backend();
$response = $backend->configdpRun("systemhealth fetch ", array($rrd_details['filename']));
$xml = simplexml_load_string($response); /* XXX can cause a crash report */
} else {
$xml = false;
$xml = @simplexml_load_string($response);
}
if ($xml !== false) {