From 5d51b0f744e755d71e8645686f2e765b1ba17bde Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 24 Jul 2015 08:24:53 +0000 Subject: [PATCH] (legacy) dependencies / uninitialized vars in dyndns --- src/www/services_dyndns.php | 4 +++- src/www/services_dyndns_edit.php | 1 + src/www/services_rfc2136.php | 2 +- src/www/services_rfc2136_edit.php | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/www/services_dyndns.php b/src/www/services_dyndns.php index cb6436c72..9ec06f040 100644 --- a/src/www/services_dyndns.php +++ b/src/www/services_dyndns.php @@ -30,8 +30,10 @@ require_once("guiconfig.inc"); require_once("interfaces.inc"); require_once("services.inc"); +require_once("interfaces.inc"); +require_once("pfsense-utils.inc"); -if (!is_array($config['dyndnses']['dyndns'])) +if (!isset($config['dyndnses']['dyndns'])) $config['dyndnses']['dyndns'] = array(); $a_dyndns = &$config['dyndnses']['dyndns']; diff --git a/src/www/services_dyndns_edit.php b/src/www/services_dyndns_edit.php index cbd4680d5..49e3dc1d2 100644 --- a/src/www/services_dyndns_edit.php +++ b/src/www/services_dyndns_edit.php @@ -29,6 +29,7 @@ require_once("guiconfig.inc"); require_once("pfsense-utils.inc"); require_once("services.inc") ; +require_once("interfaces.inc"); /* returns true if $uname is a valid DynDNS username */ function is_dyndns_username($uname) { diff --git a/src/www/services_rfc2136.php b/src/www/services_rfc2136.php index 00d6b3f1f..ce7aca425 100644 --- a/src/www/services_rfc2136.php +++ b/src/www/services_rfc2136.php @@ -31,7 +31,7 @@ require_once("guiconfig.inc"); require_once("interfaces.inc"); require_once("services.inc"); -if (!is_array($config['dnsupdates']['dnsupdate'])) +if (!isset($config['dnsupdates']['dnsupdate'])) $config['dnsupdates']['dnsupdate'] = array(); $a_rfc2136 = &$config['dnsupdates']['dnsupdate']; diff --git a/src/www/services_rfc2136_edit.php b/src/www/services_rfc2136_edit.php index 4f79588a7..c8c04ebf1 100644 --- a/src/www/services_rfc2136_edit.php +++ b/src/www/services_rfc2136_edit.php @@ -30,7 +30,7 @@ require_once("guiconfig.inc"); require_once("services.inc"); -if (!is_array($config['dnsupdates']['dnsupdate'])) { +if (!isset($config['dnsupdates']['dnsupdate'])) { $config['dnsupdates']['dnsupdate'] = array(); }