From 5d238412ae5006fd69b89fb0a42b130d4f53767f Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Sun, 23 Oct 2016 17:11:01 +0200 Subject: [PATCH] www: prepare to die! fix validation code now that issue is triggered PR: https://forum.opnsense.org/index.php?topic=3824 --- src/www/guiconfig.inc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/www/guiconfig.inc b/src/www/guiconfig.inc index 87058df8b..a9ef1b6cf 100644 --- a/src/www/guiconfig.inc +++ b/src/www/guiconfig.inc @@ -168,10 +168,7 @@ function do_input_validation($postdata, $reqdfields, $reqdfieldsn, &$input_error } for ($i = 0; $i < count($reqdfields); $i++) { - // why.. do you want to do this? we send data to validate and then validate something else.... - // can't now for sure if any page uses this wrong behaviour, but it should die eventually. - // TODO: kill - if (empty($_POST[$reqdfields[$i]]) && empty($_REQUEST[$reqdfields[$i]])) { + if (empty($postdata[$reqdfields[$i]])) { $input_errors[] = sprintf(gettext("The field %s is required."), $reqdfieldsn[$i]); } }