diff --git a/src/etc/config.xml b/src/etc/config.xml index c3d07ead2..0db4e2f61 100644 --- a/src/etc/config.xml +++ b/src/etc/config.xml @@ -447,7 +447,6 @@ inet lan - 0100000101 lan @@ -460,7 +459,6 @@ inet6 lan - 0100000102 lan diff --git a/src/etc/inc/filter_log.inc b/src/etc/inc/filter_log.inc index b6d2eb2a2..ffba0768d 100644 --- a/src/etc/inc/filter_log.inc +++ b/src/etc/inc/filter_log.inc @@ -144,7 +144,6 @@ function parse_filter_line($line) { $flent['rulenum'] = $rule_data[$field++]; $flent['subrulenum'] = $rule_data[$field++]; $flent['anchor'] = $rule_data[$field++]; - $flent['tracker'] = $rule_data[$field++]; $flent['realint'] = $rule_data[$field++]; $flent['interface'] = convert_real_interface_to_friendly_descr($flent['realint']); $flent['reason'] = $rule_data[$field++]; @@ -277,17 +276,14 @@ function get_port_with_service($port, $proto) { return ':' . $portstr; } -function find_rule_by_number($rulenum, $trackernum, $type="block") { +function find_rule_by_number($rulenum, $type="block") { global $g; /* Passing arbitrary input to grep could be a Very Bad Thing(tm) */ - if (!is_numeric($rulenum) || !is_numeric($trackernum) || !in_array($type, array('pass', 'block', 'match', 'rdr'))) + if (!is_numeric($rulenum) || !in_array($type, array('pass', 'block', 'match', 'rdr'))) return; - if ($trackernum == "0") - $lookup_pattern = "^@{$rulenum}\([0-9]+\)[[:space:]]{$type}[[:space:]].*[[:space:]]log[[:space:]]"; - else - $lookup_pattern = "^@[0-9]+\({$trackernum}\)[[:space:]]{$type}[[:space:]].*[[:space:]]log[[:space:]]"; + $lookup_pattern = "^@{$rulenum}\([0-9]+\)[[:space:]]{$type}[[:space:]].*[[:space:]]log[[:space:]]"; /* At the moment, miniupnpd is the only thing I know of that generates logging rdr rules */ @@ -330,13 +326,9 @@ function buffer_rules_load() { if (is_array($buffer)) { foreach ($buffer as $line) { list($key, $value) = explode (" ", $line, 2); - # pfctl rule number output with tracker number: @dd(dddddddddd) $matches = array(); - if (preg_match('/\@(?P\d+)\((?\d+)\)/', $key, $matches) == 1) { - if ($matches['trackernum'] > 0) - $key = $matches['trackernum']; - else - $key = "@{$matches['rulenum']}"; + if (preg_match('/\@(?P\d+)\)/', $key, $matches) == 1) { + $key = "@{$matches['rulenum']}"; } $buffer_rules_normal[$key] = $value; } @@ -349,13 +341,10 @@ function buffer_rules_clear() { unset($GLOBALS['buffer_rules_rdr']); } -function find_rule_by_number_buffer($rulenum, $trackernum, $type){ +function find_rule_by_number_buffer($rulenum, $type){ global $g, $buffer_rules_rdr, $buffer_rules_normal; - if ($trackernum == "0") - $lookup_key = "@{$rulenum}"; - else - $lookup_key = $trackernum; + $lookup_key = "@{$rulenum}"; if ($type == "rdr") { $ruleString = $buffer_rules_rdr[$lookup_key]; diff --git a/src/etc/inc/upgrade_config.inc b/src/etc/inc/upgrade_config.inc index 67c9e7c28..4e84d5965 100644 --- a/src/etc/inc/upgrade_config.inc +++ b/src/etc/inc/upgrade_config.inc @@ -3307,27 +3307,6 @@ function upgrade_105_to_106() { function upgrade_106_to_107() { global $config; - if (is_array($config['filter']) && is_array($config['filter']['rule'])) { - $tracker = (int)microtime(true); - foreach ($config['filter']['rule'] as $ridx => $rule) { - if (empty($rule['tracker'])) { - $config['filter']['rule'][$ridx]['tracker'] = $tracker; - $tracker++; - } - } - unset($tracker, $ridx); - } - if (is_array($config['nat']) && is_array($config['nat']['rule'])) { - $tracker = (int)microtime(true); - foreach ($config['nat']['rule'] as $ridx => $rule) { - if (empty($rule['tracker'])) { - $config['nat']['rule'][$ridx]['tracker'] = $tracker; - $tracker++; - } - - } - unset($tracker, $ridx); - } } function upgrade_107_to_108() { diff --git a/src/www/diag_logs_filter.php b/src/www/diag_logs_filter.php index 997c18f4d..c0f196da6 100644 --- a/src/www/diag_logs_filter.php +++ b/src/www/diag_logs_filter.php @@ -69,8 +69,8 @@ function getGETPOSTsettingvalue($settingname, $default) $rulenum = getGETPOSTsettingvalue('getrulenum', null); if($rulenum) { - list($rulenum, $tracker, $type) = explode(',', $rulenum); - $rule = find_rule_by_number($rulenum, $tracker, $type); + list($rulenum, $type) = explode(',', $rulenum); + $rule = find_rule_by_number($rulenum, $type); echo gettext("The rule that triggered this action is") . ":\n\n{$rule}"; exit; } @@ -326,7 +326,7 @@ include("head.inc"); $rowIndex++;?> - ', outputrule);" title=""> + ', outputrule);" title=""> @@ -336,7 +336,7 @@ include("head.inc"); ".find_rule_by_number_buffer($filterent['rulenum'],$filterent['tracker'],$filterent['act']).""); + echo("".find_rule_by_number_buffer($filterent['rulenum'],$filterent['act']).""); $int = strtolower($filterent['interface']); $proto = strtolower($filterent['proto']); @@ -374,7 +374,7 @@ include("head.inc"); - +