lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-13 00:07:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

System: Trust: Authorities - prevent recusrion loop when ca's are cross referencing eachother.

Browse Source 
Although this is highly uncommon, it's very annoying when the certificate path leads to an "Fatat error: Allowed memory size exhausted...".
If we do end in a loop (e.g. same ca already in the path), exit the calculation and return what we found sofar.
This commit is contained in:
Ad Schellevis 2025-04-08 11:41:04 +02:00
parent d240c8b0fa
commit 5629911558
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/etc/inc/certs.inc
View File

@ -107,6 +107,9 @@ function ca_chain_array(&$cert)
$crt = false;
}
if ($crt) {
if (in_array($crt, $chain)) {
break; /* exit endless loop */
}
$chain[] = $crt;
}
}

6
src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
View File

@ -596,7 +596,11 @@ class Store
{
$chain = [];
while (($item = self::getCA(!isset($item) ? $caref : $item->caref)) != null) {
$chain[] = base64_decode((string)$item->crt);
$data = base64_decode((string)$item->crt);
if (in_array($data, $chain)) {
break; /* exit endless loop */
}
$chain[] = $data;
}
return implode("\n", $chain);
}