From 557effd64a3f0462f0ce684cb3c356ba6e30e3da Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Wed, 8 Nov 2017 19:27:32 +0100 Subject: [PATCH] api, dns / firewall live log. change output to associative array so we can easily map list of results. https://github.com/opnsense/core/issues/1788 --- .../controllers/OPNsense/Diagnostics/Api/DnsController.php | 2 +- src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php index b83d5f399..199412ece 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php @@ -54,7 +54,7 @@ class DnsController extends ApiControllerBase } $result = array(); foreach ($address as $addr) { - $result[] = gethostbyaddr($addr); + $result[$addr] = gethostbyaddr($addr); } return $result; } else { diff --git a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt index 5da823372..bd78c9252 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt @@ -122,9 +122,9 @@ POSSIBILITY OF SUCH DAMAGE. $(this).unbind('click'); $(".act_info_fld_src, .act_info_fld_dst").each(function(){ var target_field = $(this); - ajaxGet(url='/api/diagnostics/dns/reverse_lookup', {'address': $(this).text()}, callback=function(data, status) { - if (Array.isArray(data)) { - var resolv_output = data.join(','); + ajaxGet(url='/api/diagnostics/dns/reverse_lookup', {'address': target_field.text()}, callback=function(data, status) { + if (data[target_field.text()] != undefined) { + var resolv_output = data[target_field.text()]; if (target_field.text() != resolv_output) { target_field.text(target_field.text() + ' [' + resolv_output + ']'); }