From 552f86f9ea7113ef11690e273dcd9eb6d655fb04 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 10 Jun 2022 10:51:03 +0200
Subject: [PATCH] dhcp: small cleanup for previous

---
 src/etc/inc/plugins.inc.d/dhcpd.inc | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/etc/inc/plugins.inc.d/dhcpd.inc b/src/etc/inc/plugins.inc.d/dhcpd.inc
index 319d809f6..ff6072bec 100644
--- a/src/etc/inc/plugins.inc.d/dhcpd.inc
+++ b/src/etc/inc/plugins.inc.d/dhcpd.inc
@@ -1451,8 +1451,8 @@ authoritative;
 
 EOD;
 
-    $dhcpdv6ifs = array();
-    $ddns_zones = array();
+    $dhcpdv6ifs = [];
+    $ddns_zones = [];
     $need_ddns_updates = false;
 
     foreach ($dhcpdv6cfg as $dhcpv6if => $dhcpv6ifconf) {
@@ -1620,13 +1620,11 @@ EOD;
             $ddns_zones[] = $newzone;
         }
 
-        if (preg_match("/poes/si", $dhcpv6if)) {
-            /* magic here */
+        if (preg_match('/poes/si', $dhcpv6if)) {
+            /* XXX magic here */
             $dhcpdv6ifs = array_merge($dhcpdv6ifs, dhcpd_get_pppoes_child_interfaces($dhcpv6if));
         } else {
-            $realif = get_real_interface($dhcpv6if, "inet6");
-            $realif = escapeshellcmd($realif);
-            $dhcpdv6ifs[] = $realif;
+            $dhcpdv6ifs[] = escapeshellcmd(get_real_interface($dhcpv6if, 'inet6'));
         }
     }