VPN: OpenVPN: Instances - add validation "A disabled renegotiation time requires a token lifetime.". closes https://github.com/opnsense/core/pull/8203

This commit is contained in:
Ad Schellevis 2025-01-23 14:06:09 +01:00
parent e43bca743b
commit 526d747db7

View File

@ -133,11 +133,16 @@ class OpenVPN extends BaseModel
$key . ".verify_client_cert"
));
}
if ((string)$instance->{'auth-gen-token'} != '0' && (string)$instance->{'reneg-sec'} == '0') {
if (!empty((string)$instance->{'auth-gen-token'}) && (string)$instance->{'reneg-sec'} == '0') {
$messages->appendMessage(new Message(
gettext('A token lifetime requires a non zero Renegotiate time.'),
$key . ".auth-gen-token"
));
} elseif ((string)$instance->{'auth-gen-token'} == '0' && (string)$instance->{'reneg-sec'} == '0') {
$messages->appendMessage(new Message(
gettext('A disabled renegotiation time requires a token lifetime.'),
$key . ".auth-gen-token"
));
}
}
if (!empty((string)$instance->cert)) {