From 521afca1407bca500aaef7161ee77e69945c66c3 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Wed, 6 Feb 2019 08:40:31 +0100 Subject: [PATCH] rework https://github.com/opnsense/core/commit/5ad905c89729d8540f7056e8ea2f94988d35f8ff (https://github.com/opnsense/core/issues/3189), accidentally dropped support for known services ;) --- src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php index db8726c69..0dc218190 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php +++ b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php @@ -195,8 +195,9 @@ class Util $tmp = explode(':', $number); foreach ($tmp as $port) { if (!getservbyname($port, "tcp") && !getservbyname($port, "udp") - && filter_var($port, FILTER_VALIDATE_INT, array( - "options" => array("min_range"=>1, "max_range"=>65535))) === false + && (filter_var($port, FILTER_VALIDATE_INT, array( + "options" => array("min_range"=>1, "max_range"=>65535)) + ) === false || !is_numeric($port)) ) { return false; }