From 4e9baba4d0f419185665b8e0e17e1da996d276fb Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 18 Jul 2022 20:25:56 +0200 Subject: [PATCH] System: Routes: Configuration - disable flag not removing static route. closes https://github.com/opnsense/core/issues/5887 looks like a regression in https://github.com/opnsense/core/commit/52d3e7c6768b1863ac8b91d8da43d39e5c7bd364, after which delete doesn't seem to execute a valid route command. --- src/etc/inc/system.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/etc/inc/system.inc b/src/etc/inc/system.inc index 289e83aaa..ca278a48d 100644 --- a/src/etc/inc/system.inc +++ b/src/etc/inc/system.inc @@ -631,7 +631,8 @@ function system_staticroutes_configure($interface = '') $ip = $rtent['network']; if (!empty($rtent['disabled'])) { $inet = (is_subnetv6($ip) ? "-inet6" : "-inet"); - mwexec("/sbin/route delete {$inet}", true); + $cmd = " {$inet} {$blackhole} " . escapeshellarg($ip) . " "; + mwexec("/sbin/route delete {$cmd}", true); } else { $inet = (is_subnetv6($ip) ? "-inet6" : "-inet"); $cmd = " {$inet} {$blackhole} " . escapeshellarg($ip) . " ";