From 4c0f9a797ec6fd18e08e30cbbe0d8a105f58f1d4 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Tue, 19 Mar 2019 13:44:01 +0100 Subject: [PATCH] Filter, always generate hash if label isn't provided. for https://github.com/opnsense/core/issues/3312 --- src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php index 7f01d7162..df784eb14 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php +++ b/src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php @@ -242,8 +242,8 @@ class Plugin if ($defaults != null) { $conf = array_merge($defaults, $conf); } - if (empty($conf['label']) && !empty($conf['#ref'])) { - // generated rule, has an anchor but no label if it's trackable + if (empty($conf['label'])) { + // generated rule, has no label $rule_hash = Util::calcRuleHash($conf); $conf['label'] = $rule_hash; }