From 4b77d13eef0965104d202016c0dacfcee55ddf25 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Mon, 12 Aug 2024 12:49:35 +0200
Subject: [PATCH] interfaces: one hit and miss and a consistency change for
 previous

$interface isn't the device. Also use ifcfg['if'] rather than one
single stray ppp['if'] at the end of this function.
---
 src/etc/inc/interfaces.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/etc/inc/interfaces.inc b/src/etc/inc/interfaces.inc
index 11b1fa8c4..63b44cc7c 100644
--- a/src/etc/inc/interfaces.inc
+++ b/src/etc/inc/interfaces.inc
@@ -1334,7 +1334,7 @@ EOD;
     }
 
     /* precaution for post-start 'up' check */
-    legacy_interface_flags($interface, 'down', false);
+    legacy_interface_flags($ifcfg['if'], 'down', false);
 
     /* fire up mpd */
     mwexecf(
@@ -1350,7 +1350,7 @@ EOD;
     $i = 0;
     while ($i < $max) {
         sleep(1);
-        if (does_interface_exist($ppp['if'], 'up')) {
+        if (does_interface_exist($ifcfg['if'], 'up')) {
             break;
         }
         $i++;