From 4ada25398ebfadb5ffbe7b08644e07bb011ea36d Mon Sep 17 00:00:00 2001 From: kulikov-a <36099472+kulikov-a@users.noreply.github.com> Date: Tue, 31 Jan 2023 19:55:37 +0300 Subject: [PATCH] MVC/Firewall/Util - prevent possible infinite loop (#6288) Prevent possible infinite loop in getPortAlias if alias references itself somehow --- src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php index a1ac6a69d..819e52e9c 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php +++ b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php @@ -208,6 +208,7 @@ class Util $result = array(); foreach (self::$aliasObject->aliasIterator() as $node) { if (!empty($name) && (string)$node['name'] == $name && $node['type'] == 'port') { + $aliases[] = $name; foreach ($node['content'] as $address) { if (Util::isAlias($address)) { if (!in_array($address, $aliases)) {