From 4569d045ccd42de08a792ca7f606e047ae84234d Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sun, 14 Jul 2024 14:55:29 +0200 Subject: [PATCH] Firewall: Aliases - fix unexpected side-affect of https://github.com/opnsense/core/commit/902487aeccd712f5e265d9be0ea5b3c465e61cb0, closes https://github.com/opnsense/core/issues/7614 It looks like the content selector to hook the tokenizer events was too wide, which started to cause issues after we added the live search. This commit only targets the change events on the select itself prevent double execution and possible non string items to be forwarded to `tokenize2().trigger('tokenize:tokens:add',...)` --- src/opnsense/mvc/app/views/OPNsense/Firewall/alias.volt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/views/OPNsense/Firewall/alias.volt b/src/opnsense/mvc/app/views/OPNsense/Firewall/alias.volt index 56ad88cc0..af09ad9ab 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Firewall/alias.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Firewall/alias.volt @@ -252,12 +252,12 @@ }); $(".geoip_select").selectpicker(); - $(".geoip_select").change(function(){ + $("select.geoip_select").change(function(){ // unlink on change event $("#alias\\.content").unbind('tokenize:tokens:change'); // copy items from geoip fields to content field $("#alias\\.content").tokenize2().trigger('tokenize:clear'); - $(".geoip_select").each(function () { + $("select.geoip_select").each(function () { $.each($(this).val(), function(key, item){ $("#alias\\.content").tokenize2().trigger('tokenize:tokens:add', item); });