From 42dcb68784f7f9be29adfa37ec12edcf83f3ecb3 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Thu, 24 Jun 2021 14:05:23 +0200 Subject: [PATCH] ui: bootgrid tooltip improvements and missing action button conversions; closes #4608 --- .../views/OPNsense/CaptivePortal/clients.volt | 2 +- .../views/OPNsense/CaptivePortal/index.volt | 4 +-- .../OPNsense/CaptivePortal/vouchers.volt | 5 ---- .../views/OPNsense/Diagnostics/fw_states.volt | 2 +- .../app/views/OPNsense/Diagnostics/log.volt | 5 ++-- .../views/OPNsense/Diagnostics/routes.volt | 4 +-- .../views/OPNsense/Firewall/alias_util.volt | 2 +- .../app/views/OPNsense/Firewall/category.volt | 10 +++---- .../mvc/app/views/OPNsense/IDS/index.volt | 26 +++++++++---------- .../mvc/app/views/OPNsense/IDS/policy.volt | 8 +++--- .../mvc/app/views/OPNsense/Monit/index.volt | 12 ++++----- .../mvc/app/views/OPNsense/Proxy/index.volt | 14 +++++----- .../www/js/opnsense_bootgrid_plugin.js | 14 +++++----- 13 files changed, 52 insertions(+), 56 deletions(-) diff --git a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/clients.volt b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/clients.volt index c2d3a8de7..f84bf4e3d 100644 --- a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/clients.volt +++ b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/clients.volt @@ -62,7 +62,7 @@ POSSIBILITY OF SUCH DAMAGE. multiSelect: true, formatters: { "commands": function (column, row) { - return ''; + return ''; } } }; diff --git a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt index 587f21d9f..e018f36a2 100644 --- a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt +++ b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt @@ -192,8 +192,8 @@ - - + + diff --git a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt index d47a1ffa4..500f86cb7 100644 --- a/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt +++ b/src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt @@ -87,11 +87,6 @@ POSSIBILITY OF SUCH DAMAGE. ajax: false, selection: true, multiSelect: true, - formatters: { - "commands": function (column, row) { - return ""; - } - }, converters: { // convert datetime type fields from unix timestamp to readable format datetime: { diff --git a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_states.volt b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_states.volt index 03f93c11d..7276d0ad9 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_states.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_states.volt @@ -37,7 +37,7 @@ options:{ formatters:{ commands: function (column, row) { - return ''; + return ''; }, rule: function (column, row) { if (row.label !== "") { diff --git a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt index b816816d8..ee8f71c87 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt @@ -35,9 +35,8 @@ formatters:{ page: function (column, row) { if ($("input.search-field").val() !== "") { - return ""; + return ''; } else { return ""; } diff --git a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/routes.volt b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/routes.volt index 588f88ca2..b17e67c82 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/routes.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/routes.volt @@ -35,8 +35,8 @@ POSSIBILITY OF SUCH DAMAGE. formatters: { "commands": function (column, row) { return ""; + class=\"btn btn-xs btn-default command-delete bootgrid-tooltip\" \ + data-row-id=\"" + row.destination + "," + row.gateway +"\">"; } } }).on("loaded.rs.jquery.bootgrid", function(){ diff --git a/src/opnsense/mvc/app/views/OPNsense/Firewall/alias_util.volt b/src/opnsense/mvc/app/views/OPNsense/Firewall/alias_util.volt index 9dae0d8bc..0952d0333 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Firewall/alias_util.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Firewall/alias_util.volt @@ -17,7 +17,7 @@ rowCount: [20, 50, 100, 200, -1], formatters: { commands: function (column, row) { - return ''; + return ''; }, } } diff --git a/src/opnsense/mvc/app/views/OPNsense/Firewall/category.volt b/src/opnsense/mvc/app/views/OPNsense/Firewall/category.volt index b4fb4468e..e6a1b13d2 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Firewall/category.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Firewall/category.volt @@ -49,9 +49,9 @@ } }, commands: function (column, row) { - return " " + - "" + - ""; + return " " + + "" + + ""; }, boolean: function (column, row) { if (parseInt(row[column.id], 2) === 1) { @@ -107,8 +107,8 @@ - - + + diff --git a/src/opnsense/mvc/app/views/OPNsense/IDS/index.volt b/src/opnsense/mvc/app/views/OPNsense/IDS/index.volt index a07083397..23bf561c7 100644 --- a/src/opnsense/mvc/app/views/OPNsense/IDS/index.volt +++ b/src/opnsense/mvc/app/views/OPNsense/IDS/index.volt @@ -252,13 +252,13 @@ POSSIBILITY OF SUCH DAMAGE. navigation:0, formatters:{ editor: function (column, row) { - return ""; + return ""; }, boolean: function (column, row) { if (parseInt(row[column.id], 2) == 1) { - return ""; + return ""; } else { - return ""; + return ""; } } }, @@ -328,11 +328,11 @@ POSSIBILITY OF SUCH DAMAGE. rowCount:[10, 25, 50,100,500,1000] , formatters:{ rowtoggle: function (column, row) { - var toggle = " "; + var toggle = " "; if (parseInt(row[column.id], 2) == 1) { - toggle += "  "; + toggle += "  "; } else { - toggle += "  "; + toggle += "  "; } return toggle; } @@ -415,7 +415,7 @@ POSSIBILITY OF SUCH DAMAGE. requestHandler:addAlertQryFilters, formatters:{ info: function (column, row) { - return " "; + return " "; } }, converters: { @@ -832,10 +832,10 @@ POSSIBILITY OF SUCH DAMAGE. - - - - + + + + @@ -874,8 +874,8 @@ POSSIBILITY OF SUCH DAMAGE. - - + + diff --git a/src/opnsense/mvc/app/views/OPNsense/IDS/policy.volt b/src/opnsense/mvc/app/views/OPNsense/IDS/policy.volt index df851a68f..9ae948815 100644 --- a/src/opnsense/mvc/app/views/OPNsense/IDS/policy.volt +++ b/src/opnsense/mvc/app/views/OPNsense/IDS/policy.volt @@ -145,8 +145,8 @@ POSSIBILITY OF SUCH DAMAGE. - - + + @@ -171,8 +171,8 @@ POSSIBILITY OF SUCH DAMAGE. - - + + diff --git a/src/opnsense/mvc/app/views/OPNsense/Monit/index.volt b/src/opnsense/mvc/app/views/OPNsense/Monit/index.volt index bfb296ba4..0763c3cb8 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Monit/index.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Monit/index.volt @@ -283,8 +283,8 @@ - - + + @@ -307,8 +307,8 @@ - - + + @@ -331,8 +331,8 @@ - - + + diff --git a/src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt b/src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt index e24ed9fca..86a306350 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt @@ -377,8 +377,8 @@ - - + + @@ -399,8 +399,8 @@ - - + + @@ -423,8 +423,8 @@ - - + + @@ -481,7 +481,7 @@ - + diff --git a/src/opnsense/www/js/opnsense_bootgrid_plugin.js b/src/opnsense/www/js/opnsense_bootgrid_plugin.js index 2b0c2ac3a..d71638477 100644 --- a/src/opnsense/www/js/opnsense_bootgrid_plugin.js +++ b/src/opnsense/www/js/opnsense_bootgrid_plugin.js @@ -436,26 +436,28 @@ $.fn.UIBootgrid = function (params) { grid.on("loaded.rs.jquery.bootgrid", function(){ // toggle all automated tooltips $(this).find(".bootgrid-tooltip").each(function (index) { - if ($(this).hasClass('command-add')) { + if ($(this).attr('title') !== undefined) { + // keep this tooltip + } else if ($(this).hasClass('command-add')) { $(this).attr('title', $.fn.UIBootgrid.defaults.addText); } else if ($(this).hasClass('command-delete-selected')) { $(this).attr('title', $.fn.UIBootgrid.defaults.deleteSelectedText); } else if ($(this).hasClass('command-edit')) { $(this).attr('title', $.fn.UIBootgrid.defaults.editText); } else if ($(this).hasClass('command-toggle')) { - if ($(this).data('value') == 1) { + if ($(this).data('value') == 1) { $(this).attr('title', $.fn.UIBootgrid.defaults.disableText); - } else { + } else { $(this).attr('title', $.fn.UIBootgrid.defaults.enableText); - } + } } else if ($(this).hasClass('command-delete')) { $(this).attr('title', $.fn.UIBootgrid.defaults.deleteText); } else if ($(this).hasClass('command-info')) { $(this).attr('title', $.fn.UIBootgrid.defaults.infoText); } else if ($(this).hasClass('command-copy')) { $(this).attr('title', $.fn.UIBootgrid.defaults.cloneText); - } else if ($(this).attr('title') === undefined) { - $(this).attr('title', 'Error: unregistered tooltip'); + } else { + $(this).attr('title', 'Error: no tooltip match'); } $(this).tooltip(); });