From 413f49c3ef68c0269a7163410b01a19c7a2fa4b5 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 14 Apr 2025 09:47:50 +0200 Subject: [PATCH] Services: Captive Portal - configd actions should use long opts (fix regression in https://github.com/opnsense/core/commit/7e838c6d92ccb3dc1e15b0a47a4ac728116c500a) argparse needs long params too.. --- src/opnsense/scripts/OPNsense/CaptivePortal/allow.py | 8 ++++---- .../OPNsense/CaptivePortal/set_session_restrictions.py | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/opnsense/scripts/OPNsense/CaptivePortal/allow.py b/src/opnsense/scripts/OPNsense/CaptivePortal/allow.py index 6b1fcfdd4..3b7ba3760 100755 --- a/src/opnsense/scripts/OPNsense/CaptivePortal/allow.py +++ b/src/opnsense/scripts/OPNsense/CaptivePortal/allow.py @@ -36,10 +36,10 @@ from lib.arp import ARP from lib.pf import PF parser = argparse.ArgumentParser() -parser.add_argument('-username', help='username', type=str, required=True) -parser.add_argument('-zoneid', help='zone number to allow this user in', type=str, required=True) -parser.add_argument('-authenticated_via', help='authentication source', type=str) -parser.add_argument('-ip_address', help='source ip address', type=str) +parser.add_argument('--username', help='username', type=str, required=True) +parser.add_argument('--zoneid', help='zone number to allow this user in', type=str, required=True) +parser.add_argument('--authenticated_via', help='authentication source', type=str) +parser.add_argument('--ip_address', help='source ip address', type=str) args = parser.parse_args() arp_entry = ARP().get_by_ipaddress(args.ip_address) diff --git a/src/opnsense/scripts/OPNsense/CaptivePortal/set_session_restrictions.py b/src/opnsense/scripts/OPNsense/CaptivePortal/set_session_restrictions.py index 631685fc5..c1f3014e0 100755 --- a/src/opnsense/scripts/OPNsense/CaptivePortal/set_session_restrictions.py +++ b/src/opnsense/scripts/OPNsense/CaptivePortal/set_session_restrictions.py @@ -31,9 +31,9 @@ import ujson from lib.db import DB parser = argparse.ArgumentParser() -parser.add_argument('-zoneid', help='zone number to allow this user in', type=str, required=True) -parser.add_argument('-sessionid', help='session id', type=str, required=True) -parser.add_argument('-session_timeout', help='authentication source', type=str) +parser.add_argument('--zoneid', help='zone number to allow this user in', type=str, required=True) +parser.add_argument('--sessionid', help='session id', type=str, required=True) +parser.add_argument('--session_timeout', help='authentication source', type=str) args = parser.parse_args()