From 3fe3591f6b8f148debdfcdebfb1ee648550bfaaa Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Mon, 30 Sep 2024 15:54:11 +0200
Subject: [PATCH] system: put picture link back and fix type conversion issue
 #7907

---
 .../app/controllers/OPNsense/Core/Api/DashboardController.php   | 2 +-
 src/opnsense/www/js/widgets/Metadata/Core.xml                   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php
index 7060bd266..875593fb2 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DashboardController.php
@@ -128,7 +128,7 @@ class DashboardController extends ApiControllerBase
                 $translations = (array)($metadataAttributes->translations ?? []);
 
                 if (!empty($link) && !$this->canAccessEndpoints([$link])) {
-                    $link = null;
+                    $link = '';
                 }
 
                 if (!$this->canAccessEndpoints($endpoints)) {
diff --git a/src/opnsense/www/js/widgets/Metadata/Core.xml b/src/opnsense/www/js/widgets/Metadata/Core.xml
index 9975e208c..750fef0bd 100644
--- a/src/opnsense/www/js/widgets/Metadata/Core.xml
+++ b/src/opnsense/www/js/widgets/Metadata/Core.xml
@@ -339,6 +339,7 @@
     </openvpnservers>
     <picture>
         <filename>Picture.js</filename>
+        <link>/system_general.php</link>
         <endpoints>
             <endpoint>/api/core/dashboard/picture</endpoint>
         </endpoints>