From 3a70baedec12f5d592a789a04f3c6f6331f0ca60 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Wed, 18 Oct 2023 20:40:09 +0200 Subject: [PATCH] MVC/PortField - minor regression in setEnableAlias() always turning our content into lower case items. since known portnames are lowercase, let's check if case matters and only lowercase in these cases. --- .../app/models/OPNsense/Base/FieldTypes/PortField.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php index 439032c99..e6e0a6f24 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php @@ -164,12 +164,18 @@ class PortField extends BaseListField } /** - * always lowercase portnames + * always lowercase known portnames * @param string $value */ public function setValue($value) { - parent::setValue(trim(strtolower($value))); + $tmp = trim(strtolower($value)); + if ($this->enableWellKnown && in_array($tmp, ["any"] + self::$wellknownservices)) { + return parent::setValue($tmp); + } else { + return parent::setValue($value); + } + } /**