From 3a3bb837c55e6fe5969f6829402789ca1c0ced33 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 6 Nov 2017 20:48:09 +0100 Subject: [PATCH] api dns, better to use parameter for address (list) https://github.com/opnsense/core/issues/1788 --- .../OPNsense/Diagnostics/Api/DnsController.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php index b922c32dc..b83d5f399 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/DnsController.php @@ -41,14 +41,17 @@ class DnsController extends ApiControllerBase /** * perform a reverse dns lookup - * @param string|array $address ip address or list of addresses * @return array */ - public function reverse_lookupAction($address) + public function reverse_lookupAction() { - if ($this->request->isGet()) { + if ($this->request->isGet() && $this->request->has('address')) { $this->sessionClose(); // long running action, close session - $address = !is_array($address) ? array($address) : $address; + if (is_array($this->request->get('address'))) { + $address = $this->request->get('address'); + } else { + $address = array($this->request->get('address')); + } $result = array(); foreach ($address as $addr) { $result[] = gethostbyaddr($addr);