From 38a68670852f60490c5d310129bad2a86cafd7ea Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Tue, 5 Jun 2018 14:27:11 +0200
Subject: [PATCH] system: fix for % usage in exec_safe/mwexecf #2443

---
 src/etc/inc/gwlb.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/etc/inc/gwlb.inc b/src/etc/inc/gwlb.inc
index ca1b9f952..7c813d95b 100644
--- a/src/etc/inc/gwlb.inc
+++ b/src/etc/inc/gwlb.inc
@@ -423,9 +423,6 @@ EOD;
         /* identifier */
         $params .= exec_safe('-i %s ', $name);
 
-        /* bind src address */
-        $params .= exec_safe('-B %s ', $gwifip);
-
         /* PID filename */
         $params .= exec_safe('-p %s ', "/var/run/dpinger_{$name}.pid");
 
@@ -480,7 +477,10 @@ EOD;
         );
 
         /* daemonises forground mode because background mode does not work? */
-        mwexecf_bg("/usr/local/bin/dpinger -f {$params} %s", array($gateway['monitor']));
+        mwexecf_bg(
+            "/usr/local/bin/dpinger -f {$params} -B %s %s",
+            array($gwifip, $gateway['monitor'])
+        );
     }
 
     if (!isset($config['system']['prefer_dpinger'])) {