From 33004e879c115ce81752accee08bc9b707649458 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Wed, 27 Jan 2016 13:16:45 +0100 Subject: [PATCH] firewall: don't leak NAT rules into interface tab; closes #695 --- src/www/firewall_rules.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php index d81ed9267..e6c97f4c1 100644 --- a/src/www/firewall_rules.php +++ b/src/www/firewall_rules.php @@ -386,7 +386,8 @@ $( document ).ready(function() { // select icon if (!isset($filterent['type']) && empty($filterent['disabled'])) { // not very nice.... associated NAT rules don't have a type... - $iconfn = "glyphicon-play text-success"; + // NAT rules shouldn't leak into the rules screen, breaks on edit + continue; } else if (!isset($filterent['type']) && !empty($filterent['disabled'])) { $iconfn = "glyphicon-play text-muted"; } elseif ($filterent['type'] == "block" && empty($filterent['disabled'])) {