diff --git a/src/www/system_camanager.php b/src/www/system_camanager.php index ec14c9fce..aa615c8f3 100644 --- a/src/www/system_camanager.php +++ b/src/www/system_camanager.php @@ -40,14 +40,14 @@ $openssl_digest_algs = array("sha1", "sha224", "sha256", "sha384", "sha512"); $pgtitle = array(gettext("System"), gettext("Certificate Authority Manager")); -if (is_numericint($_GET['id'])) { +if (isset($_GET['id']) && is_numericint($_GET['id'])) { $id = $_GET['id']; } if (isset($_POST['id']) && is_numericint($_POST['id'])) { $id = $_POST['id']; } -if (!is_array($config['ca'])) { +if (!isset($config['ca']) || !is_array($config['ca'])) { $config['ca'] = array(); } @@ -59,14 +59,16 @@ if (!is_array($config['cert'])) { $a_cert =& $config['cert']; -if (!is_array($config['crl'])) { +if (!isset($config['crl']) || !is_array($config['crl'])) { $config['crl'] = array(); } $a_crl =& $config['crl']; -$act = $_GET['act']; -if ($_POST['act']) { +$act=null; +if (isset($_GET['act'])) { + $act = $_GET['act']; +} elseif (isset($_POST['act'])) { $act = $_POST['act']; } @@ -99,7 +101,7 @@ if ($act == "del") { } if ($act == "edit") { - if (!$a_ca[$id]) { + if (!isset($a_ca[$id])) { redirectHeader("system_camanager.php"); exit; } @@ -113,7 +115,11 @@ if ($act == "edit") { } if ($act == "new") { - $pconfig['method'] = $_GET['method']; + if (isset($_GET['method'])) { + $pconfig['method'] = $_GET['method']; + } else { + $pconfig['method'] = null ; + } $pconfig['keylen'] = "2048"; $pconfig['digest_alg'] = "sha256"; $pconfig['lifetime'] = "365"; @@ -251,9 +257,13 @@ if ($_POST) { $ca = $a_ca[$id]; } - $ca['descr'] = $pconfig['descr']; + if (isset($pconfig['descr'])) { + $ca['descr'] = $pconfig['descr']; + } else { + $ca['descr'] = null; + } - if ($_POST['edit'] == "edit") { + if (isset($_POST['edit']) && $_POST['edit'] == "edit") { $ca['descr'] = $pconfig['descr']; $ca['refid'] = $pconfig['refid']; $ca['serial'] = $pconfig['serial']; @@ -305,12 +315,12 @@ if ($_POST) { if (!$input_errors) { write_config(); + unset($input_errors); } // redirectHeader("system_camanager.php"); } } - include("head.inc"); $main_buttons = array( @@ -373,7 +383,7 @@ function method_change() {