From 2f426ba4199db691591b4ff7c958cb92f063c2b1 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sun, 15 Oct 2017 18:14:08 +0200 Subject: [PATCH] network insight / export, return empty file when parameters are missing. closes https://github.com/opnsense/core/issues/1454 --- .../OPNsense/Diagnostics/Api/NetworkinsightController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php index 2f10aa77e..e0fec8224 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php @@ -261,7 +261,7 @@ class NetworkinsightController extends ApiControllerBase ) { $this->response->setRawHeader("Content-Type: application/octet-stream"); $this->response->setRawHeader("Content-Disposition: attachment; filename=".$provider.".csv"); - if ($this->request->isGet()) { + if ($this->request->isGet() && $provider != null && $resolution != null ) { $backend = new Backend(); $configd_cmd = "netflow aggregate export {$provider} {$from_date} {$to_date} {$resolution}"; $response = $backend->configdRun($configd_cmd);