From 2e1458795533181bcdb23d311dc196bc39dbc523 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Thu, 21 Feb 2019 21:04:05 +0100
Subject: [PATCH] Auth, add example authentication service and some filename
 cleansing. for https://github.com/opnsense/core/issues/3242

---
 .../OPNsense/Auth/AuthenticationFactory.php   |  4 +-
 .../Auth/Services/Opnsense_Auth_Test.php      | 40 +++++++++++++++++++
 2 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 src/opnsense/mvc/app/library/OPNsense/Auth/Services/Opnsense_Auth_Test.php

diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php b/src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php
index 1e5ed66d7..311a4f205 100644
--- a/src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php
+++ b/src/opnsense/mvc/app/library/OPNsense/Auth/AuthenticationFactory.php
@@ -146,9 +146,11 @@ class AuthenticationFactory
      */
     public function getService($service_name)
     {
+        // cleanse service name
+        $srv_name = str_replace('-', '_', strtolower($service_name));
         foreach (glob(__DIR__."/Services/*.php") as $filename) {
             $srv_found = basename($filename, '.php');
-            if (strtolower($srv_found) == strtolower($service_name)) {
+            if (strtolower($srv_found) == $srv_name) {
                 $reflClass = new \ReflectionClass("OPNsense\\Auth\\Services\\{$srv_found}");
                 if ($reflClass->implementsInterface('OPNsense\\Auth\\IService')) {
                     return $reflClass->newInstance();
diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/Services/Opnsense_Auth_Test.php b/src/opnsense/mvc/app/library/OPNsense/Auth/Services/Opnsense_Auth_Test.php
new file mode 100644
index 000000000..8a4efe0de
--- /dev/null
+++ b/src/opnsense/mvc/app/library/OPNsense/Auth/Services/Opnsense_Auth_Test.php
@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * Copyright (C) 2019 Deciso B.V.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
+ * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
+ * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
+ * OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+namespace OPNsense\Auth\Services;
+
+use OPNsense\Core\Config;
+use OPNsense\Auth\IService;
+
+/**
+ * opnsense test service
+ * @package OPNsense\Auth
+ */
+class OPNsense_Auth_Test extends System
+{
+}