From 2da105f07832dbbeb8e4f296796b065651f41de8 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 27 Jan 2016 13:44:57 +0100
Subject: [PATCH] firewall: tweak previous

---
 src/www/firewall_rules.php | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php
index e6c97f4c1..f86197ed5 100644
--- a/src/www/firewall_rules.php
+++ b/src/www/firewall_rules.php
@@ -383,14 +383,15 @@ $( document ).ready(function() {
                 if ((!isset($filterent['floating']) && $selected_if == $filterent['interface']) ||
                      (isset($filterent['floating']) && $selected_if == 'FloatingRules')):
                   $interface_has_rules = true;
-                  // select icon
-                  if (!isset($filterent['type']) && empty($filterent['disabled'])) {
+
+                  if (!isset($filterent['type'])) {
                       // not very nice.... associated NAT rules don't have a type...
                       // NAT rules shouldn't leak into the rules screen, breaks on edit
                       continue;
-                  } else if (!isset($filterent['type']) && !empty($filterent['disabled'])) {
-                      $iconfn = "glyphicon-play text-muted";
-                  } elseif ($filterent['type'] == "block" && empty($filterent['disabled'])) {
+                  }
+
+                  // select icon
+                  if ($filterent['type'] == "block" && empty($filterent['disabled'])) {
                       $iconfn = "glyphicon-remove text-danger";
                   } elseif ($filterent['type'] == "block" && !empty($filterent['disabled'])) {
                       $iconfn = "glyphicon-remove text-muted";