diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php index ae1014186..a9870b3a0 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php @@ -315,29 +315,28 @@ class FirmwareController extends ApiControllerBase */ public function changelogAction($version) { - $this->sessionClose(); // long running action, close session - $backend = new Backend(); - $response = array(); + $response = ['status' => 'failure']; if (!$this->request->isPost()) { return $response; } + $this->sessionClose(); // long running action, close session + $filter = new \Phalcon\Filter(); $filter->add('version', function ($value) { return preg_replace('/[^0-9a-zA-Z\.]/', '', $value); }); $version = $filter->sanitize($version, 'version'); - if ($version == 'update') { - $backend->configdRun('firmware changelog fetch'); - } else { - $html = trim($backend->configdRun(sprintf('firmware changelog html %s', $version))); - if (!empty($html)) { - $response['html'] = $html; - } + $backend = new Backend(); + $html = trim($backend->configdRun(sprintf('firmware changelog html %s', $version))); + if (!empty($html)) { + $response['status'] = 'ok'; + $response['html'] = $html; } + return $response; }