diff --git a/src/opnsense/www/js/opnsense_ui.js b/src/opnsense/www/js/opnsense_ui.js index 061f44d88..5fea43e0a 100644 --- a/src/opnsense/www/js/opnsense_ui.js +++ b/src/opnsense/www/js/opnsense_ui.js @@ -276,7 +276,6 @@ function addMultiSelectClearUI() { function initFormHelpUI() { // handle help messages show/hide $("a[class='showhelp']").click(function (event) { - $("*[for='" + $(this).attr('id') + "']").toggleClass("hidden show"); $("*[data-for='" + $(this).attr('id') + "']").toggleClass("hidden show"); event.preventDefault(); }); @@ -289,13 +288,9 @@ function initFormHelpUI() { if (window.sessionStorage) { sessionStorage.setItem('all_help_preset', 1); } - $('[for*="help_for"]').addClass("show"); - $('[for*="help_for"]').removeClass("hidden"); $('[data-for*="help_for"]').addClass("show"); $('[data-for*="help_for"]').removeClass("hidden"); } else { - $('[for*="help_for"]').addClass("hidden"); - $('[for*="help_for"]').removeClass("show"); $('[data-for*="help_for"]').addClass("hidden"); $('[data-for*="help_for"]').removeClass("show"); if (window.sessionStorage) { @@ -308,8 +303,6 @@ function initFormHelpUI() { // show all help messages when preset was stored $('[id*="show_all_help"]').toggleClass("fa-toggle-on fa-toggle-off"); $('[id*="show_all_help"]').toggleClass("text-success text-danger"); - $('[for*="help_for"]').addClass("show"); - $('[for*="help_for"]').removeClass("hidden"); $('[data-for*="help_for"]').addClass("show"); $('[data-for*="help_for"]').removeClass("hidden"); } diff --git a/src/www/head.inc b/src/www/head.inc index df77cabe2..2ec58b435 100644 --- a/src/www/head.inc +++ b/src/www/head.inc @@ -142,7 +142,6 @@ $pagetitle .= html_safe(sprintf(' | %s.%s', $config['system']['hostname'], $conf // link showhelp class behavior $("a[class='showhelp']").click(function (event) { - $("*[for='" + $(this).attr('id') + "']").toggleClass("hidden show"); $("*[data-for='" + $(this).attr('id') + "']").toggleClass("hidden show"); event.preventDefault(); }); @@ -155,16 +154,12 @@ $pagetitle .= html_safe(sprintf(' | %s.%s', $config['system']['hostname'], $conf if (window.sessionStorage) { sessionStorage.setItem('all_help_preset', 1); } - $('[for*="help_for"]').addClass("show"); - $('[for*="help_for"]').removeClass("hidden"); $('[data-for*="help_for"]').addClass("show"); $('[data-for*="help_for"]').removeClass("hidden"); } else { if (window.sessionStorage) { sessionStorage.setItem('all_help_preset', 0); } - $('[for*="help_for"]').addClass("hidden"); - $('[for*="help_for"]').removeClass("show"); $('[data-for*="help_for"]').addClass("hidden"); $('[data-for*="help_for"]').removeClass("show"); } @@ -174,8 +169,6 @@ $pagetitle .= html_safe(sprintf(' | %s.%s', $config['system']['hostname'], $conf // show all help messages when preset was stored $('[id*="show_all_help"]').toggleClass("fa-toggle-on fa-toggle-off"); $('[id*="show_all_help"]').toggleClass("text-success text-danger"); - $('[for*="help_for"]').addClass("show"); - $('[for*="help_for"]').removeClass("hidden"); $('[data-for*="help_for"]').addClass("show"); $('[data-for*="help_for"]').removeClass("hidden"); } diff --git a/src/www/system_advanced_admin.php b/src/www/system_advanced_admin.php index 76be03347..b2ce676c3 100644 --- a/src/www/system_advanced_admin.php +++ b/src/www/system_advanced_admin.php @@ -531,14 +531,14 @@ $(document).ready(function() {