From 2ba1c056046967b61c74ee100bfa52ad3da49e36 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 22 Apr 2016 19:33:24 +0200 Subject: [PATCH] (filter, alias) fix empty update frequency, excessive downloads --- src/etc/inc/pfsense-utils.inc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/etc/inc/pfsense-utils.inc b/src/etc/inc/pfsense-utils.inc index b3a833b68..d1abffb87 100644 --- a/src/etc/inc/pfsense-utils.inc +++ b/src/etc/inc/pfsense-utils.inc @@ -458,9 +458,13 @@ function process_alias_urltable($name, $url, $freq, $forceupdate=false) { unlink($urltable_prefix); mkdir($urltable_prefix); } - + if (empty($freq)) { + $update_freq = 86400 - 90; + } else { + $update_freq = $freq * 86400 - 90; + } // If the file doesn't exist or is older than update_freq days, fetch a new copy. - if (!file_exists($urltable_filename) || ((time() - filemtime($urltable_filename)) > ($freq * 86400 - 90)) || $forceupdate) { + if (!file_exists($urltable_filename) || ((time() - filemtime($urltable_filename)) > $update_freq) || $forceupdate) { // open file handle to output file, in case the process takes a lot of time, make sure there's a file before // filter starts to load. Also helps for tracking progress. //