From 29b1489fda8196f4d60919b7f3df3fab6b5181ef Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 6 Apr 2020 13:04:58 +0200 Subject: [PATCH] MVC: while looking at https://github.com/opnsense/core/pull/4019 noticed a wrong security model for the multiselect toggle, which could lead to unaccesible data in portfield and modelfields. (some php versions seem to ignore this) --- .../mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php index 70372d90e..f211e9562 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php @@ -55,7 +55,7 @@ abstract class BaseListField extends BaseField /** * @var bool field may contain multiple interfaces at once */ - private $internalMultiSelect = false; + protected $internalMultiSelect = false; /** * @var string default validation message string