diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php index bd2be4c44..2bfe55c70 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php @@ -186,7 +186,7 @@ class VipSettingsController extends ApiMutableModelControllerBase throw new UserException(implode('
', array_slice($validations, 0, 5)), gettext("Item in use by")); } $response = $this->delBase("vip", $uuid); - if ($response['result'] ?? '' == 'deleted' && !file_exists("/tmp/delete_vip_{$uuid}.todo")) { + if (($response['result'] ?? '') == 'deleted' && !file_exists("/tmp/delete_vip_{$uuid}.todo")) { file_put_contents("/tmp/delete_vip_{$uuid}.todo", (string)$node->subnet); } return $response; diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php index 5fc3327a2..97ed7ccf2 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php +++ b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php @@ -333,11 +333,8 @@ class LDAP extends Base implements IAuthConnector public function connect($bind_url, $userdn = null, $password = null, $timeout = 30) { $retval = false; - set_error_handler( - function () { - null; - } - ); + + set_error_handler(function () { /* do nothing */ }); $this->closeLDAPHandle(); diff --git a/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php b/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php index 1ef43bc6e..e10c64060 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php +++ b/src/opnsense/mvc/app/library/OPNsense/Backup/BackupFactory.php @@ -1,32 +1,30 @@ system->remotebackup->$fieldname = base64_encode($conf[$field['name']]); } } elseif ($field['name'] == 'GDrivePasswordConfirm') { - null; // skip password confirm field + /* skip password confirm field */ } elseif (!empty($conf[$field['name']])) { $config->system->remotebackup->$fieldname = $conf[$field['name']]; } else { diff --git a/src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php b/src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php index addb0352a..c2d34f5e7 100644 --- a/src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php +++ b/src/opnsense/mvc/app/library/OPNsense/OpenVPN/ExportFactory.php @@ -58,7 +58,7 @@ class ExportFactory ); } } catch (\ReflectionException $e) { - null; // skip when unable to parse + /* skip when unable to parse */ } } return $providers; diff --git a/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php b/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php index bcc5e2d29..40719c95b 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php +++ b/src/opnsense/mvc/app/library/OPNsense/Routing/Gateways.php @@ -258,8 +258,7 @@ class Gateways } } if (!empty($thisconf['virtual']) && in_array($thisconf['name'], $reservednames)) { - // if name is already taken, don't try to add a new (virtual) entry - null; + /* if name is already taken, don't try to add a new (virtual) entry */ } elseif (($router = $this->getRouterFromFile($realif, $ipproto)) != null) { $thisconf['gateway'] = $router; if (empty($thisconf['monitor_disable']) && empty($thisconf['monitor'])) { diff --git a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php index b49d21e63..362726679 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php +++ b/src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php @@ -477,7 +477,7 @@ abstract class BaseField return $constr_class->newInstance($constraint); } } catch (ReflectionException $e) { - null; // ignore configuration errors, if the constraint can't be found, skip. + /* ignore configuration errors, if the constraint can't be found, skip. */ } } } diff --git a/src/opnsense/mvc/script/run_migrations.php b/src/opnsense/mvc/script/run_migrations.php index d32444616..664c63b33 100755 --- a/src/opnsense/mvc/script/run_migrations.php +++ b/src/opnsense/mvc/script/run_migrations.php @@ -71,7 +71,7 @@ foreach (new RecursiveIteratorIterator(new RecursiveDirectoryIterator($model_dir } } } catch (\ReflectionException $e) { - null; // cannot construct, skip + /* cannot construct, skip */ } } } diff --git a/src/www/services_dnsmasq_domainoverride_edit.php b/src/www/services_dnsmasq_domainoverride_edit.php index 5608a7f74..45812e7b8 100644 --- a/src/www/services_dnsmasq_domainoverride_edit.php +++ b/src/www/services_dnsmasq_domainoverride_edit.php @@ -65,7 +65,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { } } elseif ($_SERVER['REQUEST_METHOD'] === 'POST') { - if (isset($_GET['id']) && !empty($a_domainOverrides[$_POST['id']])) { + if (isset($_POST['id']) && !empty($a_domainOverrides[$_POST['id']])) { $id = $_POST['id']; } $input_errors= array(); diff --git a/src/www/vpn_ipsec_phase2.php b/src/www/vpn_ipsec_phase2.php index 99fe2189a..ecbed2e7d 100644 --- a/src/www/vpn_ipsec_phase2.php +++ b/src/www/vpn_ipsec_phase2.php @@ -225,6 +225,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { if (($pconfig['localid_netbits'] != 0 && !$pconfig['localid_netbits']) || !is_numeric($pconfig['localid_netbits'])) { $input_errors[] = gettext('A valid local network bit count must be specified.'); } + /* FALLTHROUGH */ case 'address': if (!$pconfig['localid_address'] || !is_ipaddr($pconfig['localid_address'])) { $input_errors[] = gettext('A valid local network IP address must be specified.');