From 236a3a7e7fa9ec9cab48b1b8c44d58f43ac01515 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Mon, 22 May 2023 13:13:30 +0200
Subject: [PATCH] interfaces: the presentation of values and extraction isn't
 ideal as all overlaps

Simplify for now and revisit this later in MVC.
---
 src/www/status_interfaces.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/www/status_interfaces.php b/src/www/status_interfaces.php
index 4732fe718..16254afe9 100644
--- a/src/www/status_interfaces.php
+++ b/src/www/status_interfaces.php
@@ -233,12 +233,11 @@ include("head.inc");
 <?php endif ?>
                 <?php if ($ifinfo['status'] != 'down'):
                   if (($ifinfo['dhcplink'] ?? '') != 'down' && ($ifinfo['pppoelink'] ?? '') != 'down' && ($ifinfo['pptplink'] ?? '') != 'down'):
-                    if (!empty($ifinfo['ipaddr'])):?>
+                    if (!empty($ifinfo['ipaddr']) /* set by get_interfaces_info() if active but not directly used */):?>
                     <tr>
                       <td><?= gettext("IPv4 address") ?></td>
                       <td>
 <?php foreach($ifinfo['ipv4'] as $ipv4): ?>
-                            <i class="fa fa-plus-square-o" aria-hidden="true"></i>
                             <?=$ipv4['ipaddr'];?>/<?=$ipv4['subnetbits'];?> <?= !empty($ipv4['vhid']) ? 'vhid ' . $ipv4['vhid'] : "" ;?>
                             <br/>
 <?php endforeach ?>
@@ -260,7 +259,8 @@ include("head.inc");
                     </tr>
 <?php
                     endif;
-                    if (!empty($ifinfo['ipaddrv6']) && !empty($ifinfo['ipv6'][0]) && !$ifinfo['ipv6'][0]['link-local']): ?>
+                    if (!empty($ifinfo['ipaddrv6']) /* set by get_interfaces_info() if active but not directly used */ &&
+                        !empty($ifinfo['ipv6'][0]) && !$ifinfo['ipv6'][0]['link-local']): ?>
                     <tr>
                       <td><?= gettext("IPv6 address") ?></td>
                       <td>