From 22a2cc9836bdd71a42ebf9f135dbc9fce91409fc Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 15 Sep 2023 13:21:49 +0200
Subject: [PATCH] system: clear a few legacy DynDNS leftovers

---
 src/etc/inc/interfaces.inc        | 3 +--
 src/etc/inc/xmlparse.inc          | 2 +-
 src/www/diag_backup.php           | 1 -
 src/www/system_gateway_groups.php | 1 -
 4 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/etc/inc/interfaces.inc b/src/etc/inc/interfaces.inc
index 09a308e10..bf91a3bd4 100644
--- a/src/etc/inc/interfaces.inc
+++ b/src/etc/inc/interfaces.inc
@@ -2349,8 +2349,7 @@ function interface_configure($verbose = false, $interface = 'wan', $reload = fal
         plugins_configure('ipsec', $verbose, [$interface]);
         plugins_configure('dhcp', $verbose);
         plugins_configure('dns', $verbose);
-        /* XXX move these up the call stack */
-        configdp_run('dyndns reload', [$interface]);
+        /* XXX move this up the call stack */
         configdp_run('rfc2136 reload', [$interface]);
     }
 
diff --git a/src/etc/inc/xmlparse.inc b/src/etc/inc/xmlparse.inc
index 36f13b4d7..d62675459 100644
--- a/src/etc/inc/xmlparse.inc
+++ b/src/etc/inc/xmlparse.inc
@@ -33,7 +33,7 @@ function listtags()
       'acls', 'alias', 'aliasurl', 'allowedip', 'allowedhostname', 'authserver',
       'bridged', 'build_port_path',
       'ca', 'cacert', 'cert', 'crl', 'clone', 'config', 'container', 'columnitem',
-       'disk', 'dnsserver', 'dnsupdate', 'domainoverrides', 'dyndns',
+      'disk', 'dnsserver', 'dnsupdate', 'domainoverrides',
       'element', 'encryption-algorithm-option',
       'field', 'fieldname',
       'gateway_item', 'gateway_group', 'gif', 'gre', 'group',
diff --git a/src/www/diag_backup.php b/src/www/diag_backup.php
index 922dda3b0..39f94590d 100644
--- a/src/www/diag_backup.php
+++ b/src/www/diag_backup.php
@@ -77,7 +77,6 @@ $areas = array(
     'dhcrelay' => gettext('DHCP Relay'),
     'dhcrelay6' => gettext('DHCPv6 Relay'),
     'dnsmasq' => gettext('Dnsmasq DNS'),
-    'dyndnses' => gettext('Dynamic DNS'),
     'dnsupdates' => gettext('RFC 2136'),
     'filter' => gettext('Firewall Rules'),
     'gateways' => gettext('Gateways'),
diff --git a/src/www/system_gateway_groups.php b/src/www/system_gateway_groups.php
index fa652624c..ad008d236 100644
--- a/src/www/system_gateway_groups.php
+++ b/src/www/system_gateway_groups.php
@@ -51,7 +51,6 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
         }
     } elseif (isset($_POST['apply'])) {
         configd_run('interface routes configure');
-        configd_run('dyndns reload');
 
         clear_subsystem_dirty('gwgroups');