diff --git a/src/www/interfaces_qinq.php b/src/www/interfaces_qinq.php index 6b2d2a5f7..5878cdeff 100644 --- a/src/www/interfaces_qinq.php +++ b/src/www/interfaces_qinq.php @@ -162,7 +162,7 @@ $main_buttons = array( $i++; endforeach; ?> - + diff --git a/src/www/interfaces_qinq_edit.php b/src/www/interfaces_qinq_edit.php index 209d9c07b..1dea77483 100644 --- a/src/www/interfaces_qinq_edit.php +++ b/src/www/interfaces_qinq_edit.php @@ -40,8 +40,8 @@ if (!isset($config['qinqs']['qinqentry']) || !is_array($config['qinqs']['qinqent $a_qinqs = &$config['qinqs']['qinqentry']; if ($_SERVER['REQUEST_METHOD'] === 'GET') { - // read form data - if (!empty($a_qinqs[$_GET['id']])) { + $id = 0; + if (isset($_GET['id']) && !empty($a_qinqs[$_GET['id']])) { $id = $_GET['id']; } $pconfig['if'] = isset($a_qinqs[$id]['if']) ? $a_qinqs[$id]['if'] : null; @@ -50,7 +50,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { $pconfig['descr'] = isset($a_qinqs[$id]['descr']) ? $a_qinqs[$id]['descr'] : null; } elseif ($_SERVER['REQUEST_METHOD'] === 'POST') { // validate / save form data - if (!empty($a_qinqs[$_POST['id']])) { + if (isset($_POST['id']) && !empty($a_qinqs[$_POST['id']])) { $id = $_POST['id']; } $input_errors = array(); @@ -72,7 +72,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { $input_errors[] = gettext("QinQ level already exists for this interface, edit it!"); } } - if (is_array($config['vlans']['vlan'])) { + if (isset($config['vlans']['vlan'])) { foreach ($config['vlans']['vlan'] as $vlan) { if ($vlan['tag'] == $pconfig['tag'] && $vlan['if'] == $pconfig['if']) { $input_errors[] = gettext("A normal VLAN exists with this tag please remove it to use this tag for QinQ first level."); @@ -214,7 +214,7 @@ include("head.inc"); " /> " onclick="window.location.href=''" /> - + diff --git a/src/www/interfaces_wireless_edit.php b/src/www/interfaces_wireless_edit.php index 21fc17c14..f40e0fcbf 100644 --- a/src/www/interfaces_wireless_edit.php +++ b/src/www/interfaces_wireless_edit.php @@ -140,67 +140,63 @@ include("head.inc");
0) print_input_errors($input_errors); ?>
-
-
-
-
- - - - - - - - - - - + + + + + + + + + +
- - -   -
- + + + + + + + + + + - - - - - - - - - -
+ + +   +
+ -
- - - -
- - - " /> - " onclick="window.location.href=''" /> - - - -
- - - + endif; + endforeach;?> + +
+ + + +
+ + + " /> + " onclick="window.location.href=''" /> + + + +
+
diff --git a/src/www/status_interfaces.php b/src/www/status_interfaces.php index 2669da88c..315ddec84 100644 --- a/src/www/status_interfaces.php +++ b/src/www/status_interfaces.php @@ -474,11 +474,11 @@ include("head.inc");
- ','')?> + "will not prevent dial-on-demand from making connections ". + "to the outside. Don't use dial-on-demand if you want to make sure that the line ". + "is kept disconnected.") ?>